Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace New().Logger with NewNopLogger() #1638

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Replace New().Logger with NewNopLogger() #1638

merged 2 commits into from
Mar 4, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Just to make it clearer that it's a no-op logger -- almost entirely test changes

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Mar 4, 2024
Merged via the queue into kolide:main with commit bf03ab5 Mar 4, 2024
31 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/newnopslogger branch March 4, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @zackattack01