Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get runtime enrollment details before osq details #1833

Merged

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Aug 13, 2024

splits enrollment details between funcs to get runtime (non-osq) enroll details and osq details

closes #1826

@James-Pickett James-Pickett marked this pull request as ready for review August 13, 2024 21:26
RebeccaMahany
RebeccaMahany previously approved these changes Aug 14, 2024
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nitpick about documentation!

pkg/osquery/enrollment_details.go Show resolved Hide resolved
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure why govet only just started to complain about fetch.go

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think good. Woo!

@James-Pickett James-Pickett added this pull request to the merge queue Aug 14, 2024
Merged via the queue into kolide:main with commit 1b40334 Aug 14, 2024
20 of 21 checks passed
@James-Pickett James-Pickett deleted the james/runtime-enrollment-details branch August 14, 2024 19:22
@RebeccaMahany RebeccaMahany added the features-improvements Features and Improvements label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features-improvements Features and Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve enrollment details via runtime data where possible
3 participants