Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set arch on bin dir when we are building for Windows #1851

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Only set arch on bin dir when we are building for Windows #1851

merged 4 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. Only set arch on bin dir when we are building for Windows

    @RebeccaMahany
    RebeccaMahany committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    16b30e2 View commit details
    Browse the repository at this point in the history

  2. Refactor launcherLocation slightly and add tests to validate location

    @RebeccaMahany
    RebeccaMahany committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3028096 View commit details
    Browse the repository at this point in the history

  3. Keep downloading arch-specific binary for all OSes

    @RebeccaMahany
    RebeccaMahany committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2f1afb2 View commit details
    Browse the repository at this point in the history

  4. Refactor and add test

    @RebeccaMahany
    RebeccaMahany committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d3ce7aa View commit details
    Browse the repository at this point in the history