Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coredump checkup for flare/doctor using coredumpctl only #1868

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Add coredump checkup for flare/doctor using coredumpctl only #1868

merged 4 commits into from
Sep 17, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Relates to #1860.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review September 17, 2024 15:47
directionless
directionless previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it has a lot of execs of coredumpctl but maybe that's unavoidable.

ee/debug/checkups/coredump_linux.go Outdated Show resolved Hide resolved
@RebeccaMahany @directionless
Update ee/debug/checkups/coredump_linux.go
88c950a 
Co-authored-by: seph <seph@kolide.co>
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Sep 17, 2024
@RebeccaMahany RebeccaMahany added the features-improvements Features and Improvements label Sep 17, 2024
Merged via the queue into kolide:main with commit 2bf00b6 Sep 17, 2024
31 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/coredump-checkup branch September 17, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
features-improvements Features and Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @directionless