Set slogger on rungroup after logshipping is set up, so that rungroup logs will be shipped

[RebeccaMahany]

Despite the changes in #1822, I wasn't seeing rungroup shutdown logs being shipped. When looking through the shipped logs, I noticed that the only rungroup logs available were either from very old versions of launcher, or from the desktop process.

This PR updates when we set the slogger on the rungroup so that we set it after the shipping handler has been added.

[directionless]

Hrm. Not sure I love the changed signature. It feels error prone.

We could maybe move NewRunGroup to after the logshipper is setup? Though it would mean moving runGroup.Add till later too

[zackattack01]

great find! this looks good to me I think you just have to fix up the watchdog_service_windows NewRunGroup call - those are only written to sqlite so I don't think order/timing should matter at all

[RebeccaMahany]

@directionless

Hrm. Not sure I love the changed signature. It feels error prone.

We could maybe move NewRunGroup to after the logshipper is setup? Though it would mean moving runGroup.Add till later too

I considered that, but felt like moving all the runGroup.Add calls later was more error prone 😅 -- we'd have one or two runGroup.Add calls to move, given that we don't add the trace exporter if we can't init it.

[James-Pickett]

nice

[RebeccaMahany]

I wanted to understand why this was happening, and figured it out. When we set the new log shipping handler, we initialize a new slogger, so the previous reference to the slogger never gets that new handler.

// we have to rebuild the handler everytime because the slogmulti package we're
// using doesn't support adding handlers after the Fanout handler has been created