batch tmutil call args to prevent argument list too long errors #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing 18k errors logged in the last two days for
fork/exec /usr/bin/tmutil: argument list too long- I am unable to reproduce this error on my machine but some brief research indicates that this is determined by theARG_MAXset per machine.We generate the filepaths for exclusion based on the output of
filepath.Globon our predefined patterns. This can also vary slightly per machine (mostly by the count of debug logs at the time this runs). To keep this simple I've approximated two equal (ish) batches of patterns, moved the exclusion logic into a helper, and run it twice. This should cut the args per call roughly in half and reduce the likelihood of hitting this error