Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added download info to flare #1878

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

cesarfda
Copy link
Contributor

@cesarfda cesarfda commented Oct 7, 2024

  • The download checkup should run only for flares

  • The download checkup should write out a list of all Kolide installers found in the downloads directory; installers will have the filename or filename suffix kolide-launcher.msi on Windows, kolide-launcher.pkg on MacOS, and kolide-launcher.rpm, kolide-launcher.deb, or kolide-launcher.pacman on Linux

Local example:
image

Closes #1753

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments, but the shape of this looks good to me overall! 🔥

ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice beginning!

ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
@cesarfda cesarfda changed the title added download info to flare, resolves #1753 added download info to flare Oct 7, 2024
James-Pickett
James-Pickett previously approved these changes Oct 7, 2024
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

directionless
directionless previously approved these changes Oct 7, 2024
ee/debug/checkups/download_directory.go Show resolved Hide resolved
ee/debug/checkups/download_directory.go Outdated Show resolved Hide resolved
zackattack01
zackattack01 previously approved these changes Oct 8, 2024
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@cesarfda cesarfda added this pull request to the merge queue Oct 8, 2024
Merged via the queue into kolide:main with commit d1c5d8f Oct 8, 2024
29 checks passed
@cesarfda cesarfda deleted the flare-download-info branch October 8, 2024 17:45
@RebeccaMahany RebeccaMahany added the features-improvements Features and Improvements label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features-improvements Features and Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add download directory information to flare
6 participants