Move osquery extension management into osquery instance #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/move-extension
branch
from
e420dea
to
f5403d4
Compare
|
|
||
| // addShutdownGoroutineToErrgroup adds the given goroutine to the errgroup, ensuring that we log its start and exit. | ||
| // The goroutine will not execute until the instance has received a signal to exit. | ||
| func (i *OsqueryInstance) addShutdownGoroutineToErrgroup(ctx context.Context, goroutineName string, goroutine func() error) { |
There was a problem hiding this comment.
these are very nice 🔥
|
|
||
| // addShutdownGoroutineToErrgroup adds the given goroutine to the errgroup, ensuring that we log its start and exit. | ||
| // The goroutine will not execute until the instance has received a signal to exit. | ||
| func (i *OsqueryInstance) addShutdownGoroutineToErrgroup(ctx context.Context, goroutineName string, goroutine func() error) { |
There was a problem hiding this comment.
these are very nice 🔥
James-Pickett
approved these changes
Oct 30, 2024
zackattack01
approved these changes
Oct 30, 2024
Comment on lines
-378
to
-382
| // Here be dragons | ||
| // | ||
| // There are two thorny issues. First, we "invert" control of | ||
| // the osquery process. We don't really know when osquery will | ||
| // be running, so we need a bunch of retries on these connections |
There was a problem hiding this comment.
This part might still be true?
There was a problem hiding this comment.
This part didn't seem relevant to keep here anymore because we don't have the retries below this method -- the code was refactored (previously) to move those retries inside the StartOsqueryClient and StartOsqueryExtensionManagerServer methods.
There was a problem hiding this comment.
Fair... the inverted control part is true, but maybe better elsewhere.
There was a problem hiding this comment.
I'll add it back as a comment in next PR!
| // the osquery process. We don't really know when osquery will | ||
| // be running, so we need a bunch of retries on these connections | ||
| // | ||
| // Second, because launcher supplements the enroll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1827
Relates to #1936.
Per ADR, moves extension management into osquery instance.
This adds two new goroutines to the osquery instance's errgroup. To simplify a bit, this PR has also added the following:
kolideextension, adding all tables tokolide_grpcinstead