Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reorganization/backfill for osquery runner and instance #1946

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Nov 8, 2024

  • Moves osquery instance tests into their own file
  • Adds TestRunnerHandlesImmediateShutdownWithMultipleInstances to validate shutdown timing
  • Adds a couple small osquery instance tests (TestHealthy_DoesNotPassForUnlaunchedInstance, TestQuery_ReturnsErrorForUnlaunchedInstance, Test_healthcheckWithRetries)
  • It's no longer possible for the knapsack to be nil inside the osquery instance, so I removed those checks
  • Refactored the healthcheck with retries into its own function for readability

@RebeccaMahany RebeccaMahany marked this pull request as ready for review November 8, 2024 17:26
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Nov 8, 2024
Merged via the queue into kolide:main with commit 4fa558a Nov 8, 2024
30 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/more-osq-tests branch November 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants