Merge pull request #119 from koliveira15/bugfix/missing-license-scan-dep

bugfix: make sonarqube dependency less strict & include license in the build
koliveira15 · Nov 12, 2024 · 22f9963 · 22f9963
2 parents 991ee6b + d2d771a
commit 22f9963
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 5 deletions.
diff --git a/LICENSE b/LICENSE
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2022 Kevin Oliveira
+Copyright (c) 2024 Kevin Oliveira
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/nx.json b/nx.json
@@ -36,6 +36,7 @@
     "sharedGlobals": ["{workspaceRoot}/.github/workflows/ci.yml"],
     "production": [
       "default",
+      "{workspaceRoot}/LICENSE",
       "!{projectRoot}/.eslintrc.json",
       "!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
       "!{projectRoot}/tsconfig.spec.json",

diff --git a/packages/nx-sonarqube/package.json b/packages/nx-sonarqube/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@koliveira15/nx-sonarqube",
+  "license": "MIT",
   "description": "A Nx plugin that scans projects using SonarQube / SonarCloud.",
   "repository": {
     "type": "git",
@@ -13,7 +14,7 @@
   "peerDependencies": {
     "@nx/devkit": ">= 16 < 20",
     "@phenomnomnominal/tsquery": "5.0.1",
-    "sonarqube-scanner": "3.1.0",
+    "sonarqube-scanner": ">= 3.1.0 < 4",
     "nx": ">= 16 < 20",
     "tslib": ">= 2.3.0 < 3"
   }

diff --git a/packages/nx-sonarqube/project.json b/packages/nx-sonarqube/project.json
@@ -13,6 +13,7 @@
         "tsConfig": "packages/nx-sonarqube/tsconfig.lib.json",
         "assets": [
           "packages/nx-sonarqube/*.md",
+          "LICENSE",
           {
             "input": "./packages/nx-sonarqube/src",
             "glob": "**/!(*.ts)",

diff --git a/packages/nx-sonarqube/src/executors/scan/executor-crystal.spec.ts b/packages/nx-sonarqube/src/executors/scan/executor-crystal.spec.ts
@@ -6,9 +6,7 @@ import {
   readJsonFile,
 } from '@nx/devkit';
 import * as sonarQubeScanner from 'sonarqube-scanner';
-import * as childProcess from 'child_process';
 import * as fs from 'fs';
-import { getScannerOptions } from './utils/utils';
 
 let projectGraph: ProjectGraph;
 let context: ExecutorContext;

diff --git a/packages/nx-sonarqube/src/executors/scan/executor.spec.ts b/packages/nx-sonarqube/src/executors/scan/executor.spec.ts
@@ -6,7 +6,6 @@ import {
   readJsonFile,
 } from '@nx/devkit';
 import * as sonarQubeScanner from 'sonarqube-scanner';
-import * as childProcess from 'child_process';
 import * as fs from 'fs';
 import { getScannerOptions } from './utils/utils';