Skip to content

Commit

Permalink
Merge branch 'main' into ws-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sahil143 committed Jan 15, 2025
2 parents f58ee37 + 7f329d6 commit e43c014
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/shared/components/pipeline-run-logs/logs/logs-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ export const getDownloadAllLogsCallback = (
allLogs += await getTaskRunLog(
workspace,
namespace,
pipelineRunUID,
taskRun?.metadata?.uid,
pipelineRunUID,
).then((log) => `${tasks[currTask].name.toUpperCase()}\n\n${log}\n\n`);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/utils/__tests__/tekton-results.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ describe('tekton-results', () => {
it('should return the latest component build task run', async () => {
commonFetchJSONMock.mockReturnValueOnce(mockLogsRecordsList);
commonFetchTextMock.mockReturnValueOnce(Promise.resolve(mockLogResponse));
expect(await getTaskRunLog('test-ws', 'test-ns', 'pipelinerun-uid', 'test-id')).toEqual(
expect(await getTaskRunLog('test-ws', 'test-ns', 'test-id', 'pipelinerun-uid')).toEqual(
'sample log',
);
expect(commonFetchTextMock.mock.calls).toEqual([
Expand Down
2 changes: 1 addition & 1 deletion src/utils/tekton-results.ts
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,8 @@ export const getTaskRuns = (
export const getTaskRunLog = (
workspace: string,
namespace: string,
pid: string,
taskRunID: string,
pid: string,
): Promise<string> =>
commonFetchText(
`${getTRUrlPrefix(workspace)}/${namespace}/results/${pid}/logs/${taskRunID}`,
Expand Down

0 comments on commit e43c014

Please sign in to comment.