fix: handle null items response #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have access to zero workspaces, then it is possible for the /workspaces query to return `null` for the items instead of `[]`. This change handles that to return `[]` onto the call. The app fails later where there is undefined behavior if the user cannot land on a workspace, but will deal with that in a later change. Signed-off-by: Ralph Bean <rbean@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 80.12% 80.12% -0.01%
==========================================
Files 578 578
Lines 21554 21555 +1
Branches 5348 5350 +2
==========================================
Hits 17270 17270
Misses 4259 4259
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM |
sahil143
approved these changes
Feb 10, 2025
The unintended behavior will be addressed by migrating to namespaces. We will implement a list page that displays an empty state, along with instructions on how to gain access to a namespace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
fixes #16
Description
If you have access to zero workspaces, then it is possible for the /workspaces query to return
nullfor the items instead of[].This change handles that to return
[]onto the call.The app fails later where there is undefined behavior if the user cannot land on a workspace, but will deal with that in a later change.
Type of change
Screen shots / Gifs for design review
None.
How to test or reproduce?
Try to use the UI pointed at the stage cluster, but with a user with no access to workspaces there.
Browser conformance: