feat!: remove the application thumbnail #106
Merged
+0
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature that may have made more sense in the past: a nice thumbnail to represent the web application we're building for the user. The idea in the past was to actually get a screenshot of the running application! https://issues.redhat.com/browse/KONFLUX-1194 .. but, we never brought that into a full feature. The icon is a randomly chosen one of 9 that is maybe just confusing for the user. If we could let the user upload and crop an icon, that might be cool: a custom logo for each application - but, that's a larger effort for another day: https://issues.redhat.com/browse/KFLUXUI-53 Signed-off-by: Ralph Bean <rbean@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 80.12% 80.08% -0.05%
==========================================
Files 578 577 -1
Lines 21554 21490 -64
Branches 5348 5069 -279
==========================================
- Hits 17270 17210 -60
+ Misses 4259 4255 -4
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sahil143
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the application thumbnail
This is a feature that may have made more sense in the past: a nice thumbnail to represent the web application we're building for the user. The idea in the past was to actually get a screenshot of the running application! https://issues.redhat.com/browse/KONFLUX-1194
.. but, we never brought that into a full feature. The icon is a randomly chosen one of 9 that is maybe just confusing for the user.
If we could let the user upload and crop an icon, that might be cool: a custom logo for each application - but, that's a larger effort for another day: https://issues.redhat.com/browse/KFLUXUI-53
Type of change
How to test or reproduce?
Just visit the application details page to see.
Browser conformance:
Footnote
If you're uncomfortable removing this or have other plans for it, feel free to reject this! No hard feelings. :)