Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-217): add contexts to show page #36

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

CryptoRodeo
Copy link
Contributor

  • Add the context values to the integration show page.
  • Add a modal to allow easy edits.
  • Use spinner for loading instead of text.

backport of openshift/hac-dev#1008

@CryptoRodeo
Copy link
Contributor Author

CryptoRodeo commented Nov 21, 2024

NOTE: depends on #25

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 90.41096% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (8041520) to head (9b6f769).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
.../components/IntegrationTests/EditContextsModal.tsx 90.62% 6 Missing ⚠️
...ionTestDetails/tabs/IntegrationTestOverviewTab.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   79.78%   79.83%   +0.05%     
==========================================
  Files         568      569       +1     
  Lines       21261    21339      +78     
  Branches     5017     5295     +278     
==========================================
+ Hits        16963    17036      +73     
- Misses       4274     4278       +4     
- Partials       24       25       +1     
Flag Coverage Δ
unittests 79.83% <90.41%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CryptoRodeo CryptoRodeo marked this pull request as ready for review November 21, 2024 20:55
@CryptoRodeo CryptoRodeo force-pushed the kfluxui-217 branch 2 times, most recently from 431106e to 4422593 Compare December 2, 2024 19:04
@CryptoRodeo CryptoRodeo requested a review from sahil143 December 2, 2024 19:04
@CryptoRodeo
Copy link
Contributor Author

CryptoRodeo commented Dec 3, 2024

I will rebase this soon now that the dependent MR has been merged.
edit: Rebased.

@CryptoRodeo CryptoRodeo marked this pull request as draft December 3, 2024 21:28
@CryptoRodeo
Copy link
Contributor Author

CryptoRodeo commented Dec 3, 2024

Converted to draft for now so I can add some spec tests for formatContexts
edit: added test.

- Add the context values to the integration show page.
- Add a modal to allow easy edits.
- Use spinner for loading instead of text.
@CryptoRodeo CryptoRodeo marked this pull request as ready for review December 3, 2024 21:39
@CryptoRodeo
Copy link
Contributor Author

Code coverage check should be safe to ignore IMO. I added an additional test to improve it. The other lines should be safe to ignore.

@JoaoPedroPP
Copy link
Contributor

LGTM

@CryptoRodeo
Copy link
Contributor Author

@sahil143 Quick question: Only certain people can merge, correct? This PR has been approved, but when I click the "Merge when ready" button it appears that the merge queue times out and the commit cannot be merged.

I'm going to assume I don't have the correct permissions to merge, even with that button being available.

@StanislavJochman
Copy link
Contributor

LGTM.

@konflux-ci konflux-ci deleted a comment from running-cara Dec 11, 2024
@testcara
Copy link
Contributor

LGTM

@sahil143
Copy link
Collaborator

@sahil143 Quick question: Only certain people can merge, correct? This PR has been approved, but when I click the "Merge when ready" button it appears that the merge queue times out and the commit cannot be merged.

I'm going to assume I don't have the correct permissions to merge, even with that button being available.

Merge queue waits for this Red Hat Konflux / konflux-ui-on-pull-request check to pass. I don't think it can run in a merge queue because once PR is added to merge queue, a temporary branch is created and all the checks start again. Konflux checks just times out and PR is removed from the queue. I am figuring out a work around for this.

@sahil143 sahil143 merged commit 3da4900 into konflux-ci:main Dec 11, 2024
4 checks passed
@CryptoRodeo CryptoRodeo deleted the kfluxui-217 branch December 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants