-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KFLUXUI-217): add contexts to show page #36
Conversation
NOTE: depends on #25 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 79.78% 79.83% +0.05%
==========================================
Files 568 569 +1
Lines 21261 21339 +78
Branches 5017 5295 +278
==========================================
+ Hits 16963 17036 +73
- Misses 4274 4278 +4
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
431106e
to
4422593
Compare
4422593
to
ea0cd30
Compare
I will rebase this soon now that the dependent MR has been merged. |
ea0cd30
to
812ece1
Compare
Converted to draft for now so I can add some spec tests for |
812ece1
to
919e405
Compare
- Add the context values to the integration show page. - Add a modal to allow easy edits. - Use spinner for loading instead of text.
919e405
to
9b6f769
Compare
Code coverage check should be safe to ignore IMO. I added an additional test to improve it. The other lines should be safe to ignore. |
LGTM |
@sahil143 Quick question: Only certain people can merge, correct? This PR has been approved, but when I click the "Merge when ready" button it appears that the merge queue times out and the commit cannot be merged. I'm going to assume I don't have the correct permissions to merge, even with that button being available. |
LGTM. |
LGTM |
Merge queue waits for this |
backport of openshift/hac-dev#1008