Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): backport-add-gitlab-annotations #47

Merged

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented Dec 3, 2024

https://issues.redhat.com/browse/KFLUXUI-205

Description
Auto detects & adds git-provider & git-url annotation to component. If undetected expands sections and allows user to select the same

Screenshots
Screenshot 2024-12-05 at 9 16 16 PM
Screenshot 2024-12-05 at 9 16 00 PM
Screenshot 2024-12-05 at 9 15 19 PM

@sahil143
Copy link
Collaborator

sahil143 commented Dec 3, 2024

/ok-to-test

@abhinandan13jan abhinandan13jan force-pushed the backport-add-gitlab-annotation branch from 62aef03 to 8a3a0d1 Compare December 5, 2024 15:39
@sahil143
Copy link
Collaborator

sahil143 commented Dec 9, 2024

/ok-to-test

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (61e9ed9) to head (b81d3af).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ents/ImportForm/ComponentSection/SourceSection.tsx 90.90% 2 Missing ⚠️
src/utils/create-utils.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   79.94%   80.01%   +0.06%     
==========================================
  Files         568      569       +1     
  Lines       21331    21380      +49     
  Branches     5278     5285       +7     
==========================================
+ Hits        17054    17108      +54     
+ Misses       4252     4247       -5     
  Partials       25       25              
Flag Coverage Δ
unittests 80.01% <95.16%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahil143
Copy link
Collaborator

/ok-to-test

Copy link
Contributor

@CryptoRodeo CryptoRodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@testcara
Copy link
Contributor

LGTM

@sahil143
Copy link
Collaborator

/ok-to-test

@sahil143 sahil143 merged commit 69a23b0 into konflux-ci:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants