-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix to namespace #53
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 80.01% 80.01% -0.01%
==========================================
Files 569 569
Lines 21379 21378 -1
Branches 5294 5037 -257
==========================================
- Hits 17107 17106 -1
- Misses 4247 4248 +1
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing to have chcao-tenant
in the Target workspace field. Usually, -tenant
is not present in the workspace name. Either we should rename the field to Target namespace. You can get UX feedback also on this.
Good point. When creating release, UI asks user to input 'chcao' as the workspace then show 'chcao-tenant' and it is really confusing. +1 to this improvement. |
7a06d7b
append suffix to namespace
Fixes
https://issues.redhat.com/browse/KONFLUX-5721
Description
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Excepted Results:
All pages show 'target namespace' and when we change the target namespace, there is no '-tenant' appended by UI.
Browser conformance: