Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix to namespace #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

testcara
Copy link
Contributor

@testcara testcara commented Dec 13, 2024

Fixes

https://issues.redhat.com/browse/KONFLUX-5721

Description

  1. We change the workspace to namespace in konflux release section.
  2. When users create/edit the release plan, konflux ui do not append the suffix '-tenant' to the input target namespace automatically.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • [] Refactoring (no functional changes, no api changes)
  • Build related changes
  • [] Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

  1. releases page
    Screenshot 2025-01-09 at 16 33 31
  2. create release page
    Screenshot 2025-01-09 at 16 34 08
  3. edit release plan
    Screenshot 2025-01-09 at 16 35 28

How to test or reproduce?

  1. Navigate to 'Releases'.
  2. Create one RPA
  3. Create one release
  4. edit the release

Excepted Results:
All pages show 'target namespace' and when we change the target namespace, there is no '-tenant' appended by UI.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (7c5807c) to head (a904c42).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   80.01%   80.01%   -0.01%     
==========================================
  Files         569      569              
  Lines       21379    21378       -1     
  Branches     5294     5037     -257     
==========================================
- Hits        17107    17106       -1     
- Misses       4247     4248       +1     
+ Partials       25       24       -1     
Flag Coverage Δ
unittests 80.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CryptoRodeo
CryptoRodeo previously approved these changes Dec 20, 2024
@testcara testcara added this pull request to the merge queue Jan 8, 2025
@sahil143 sahil143 removed this pull request from the merge queue due to a manual request Jan 8, 2025
Copy link
Collaborator

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing to have chcao-tenant in the Target workspace field. Usually, -tenant is not present in the workspace name. Either we should rename the field to Target namespace. You can get UX feedback also on this.

@testcara
Copy link
Contributor Author

testcara commented Jan 8, 2025

It's a bit confusing to have chcao-tenant in the Target workspace field. Usually, -tenant is not present in the workspace name. Either we should rename the field to Target namespace. You can get UX feedback also on this.

Good point. When creating release, UI asks user to input 'chcao' as the workspace then show 'chcao-tenant' and it is really confusing. +1 to this improvement.

@StanislavJochman StanislavJochman self-requested a review January 8, 2025 16:18
@testcara testcara dismissed stale reviews from StanislavJochman and CryptoRodeo via 7a06d7b January 9, 2025 08:31
@testcara testcara changed the title fix(KONFLUX-5721): do not add suffix '-tenant' when edit RPA fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix for creating/editing release Jan 9, 2025
@testcara testcara changed the title fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix for creating/editing release fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix for namespace Jan 9, 2025
@testcara testcara changed the title fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix for namespace fix(KONFLUX-5721): change workspace to namespace for release and do not append suffix to namespace Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants