fix(KFLUXUI-253): tekton results should filter deleted record out #55
Conversation
testcara
force-pushed
the
KFLUXUI-253
branch
2 times, most recently
from
6cf087c to
cfa1ecd
Compare
|
/retest |
testcara
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
========================================
Coverage 80.01% 80.02%
========================================
Files 569 569
Lines 21379 21383 +4
Branches 5294 5037 -257
========================================
+ Hits 17107 17111 +4
- Misses 4247 4248 +1
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
testcara
force-pushed
the
KFLUXUI-253
branch
3 times, most recently
from
0b59a41 to
7c5062b
Compare
testcara
requested review from
caugello,
CryptoRodeo,
sahil143 and
JoaoPedroPP
src/utils/tekton-results.ts
Outdated
| // When pipelines are running, the etcd would keep their results. | ||
| // deleting pipelines frome ectd would make unknown tekton results. | ||
| // Just to get meaningful test runs, we need to filter 'unknown' out. | ||
| const filteredPipelineRuns = originalPipelineRuns.filter((pipelinerun) => { | ||
| return pipelinerun.status?.conditions?.every((c) => c.status !== 'Unknown') ?? true; | ||
| }); | ||
| return [filteredPipelineRuns, list]; | ||
| }; |
There was a problem hiding this comment.
Is it possible that an unknown status will appear for the pipeline runs that were not deleted? In that case, It's not a good idea to filter out the Unknown status pipeline runs.
There was a problem hiding this comment.
Can you specify why it is not good idea?
There was a problem hiding this comment.
I just improved the filter condition to ensure it is more accurate and added more explanations. Could you help to review again? Thank you!
testcara
changed the title
Fixes
https://issues.redhat.com/browse/KFLUXUI-253
Description
When we delete one pipeline task run manually before it is completed,UI should not always keep the obsoleted run there. This patch would ignore the meaningless unknown tekton results to ensure there is no deleted but 'in process' runs on UI.
Type of change
Screen shots / Gifs for design review
Without the patch, the UI would list deleted 'running' pipelineruns.
With the patch, the UI would ignore the deleted 'running' pipelineruns.
How to test or reproduce?
Browser conformance: