fix(KFLUXUI-2): Correct GitHub App to stage environment #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
========================================
Coverage 80.01% 80.02%
========================================
Files 569 569
Lines 21380 21383 +3
Branches 5036 5287 +251
========================================
+ Hits 17108 17111 +3
+ Misses 4248 4247 -1
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM |
sahil143
requested changes
Jan 8, 2025
Comment on lines
+19
to
+23
| const internalInstance = | ||
| (host: string) => (env: EnvironmentShortName.prod | EnvironmentShortName.stage) => | ||
| new RegExp(`stone-${env}-([A-Za-z0-9]+).([a-z]+).([a-z0-9]+).openshiftapps.com`, 'g').test( | ||
| host, | ||
| ); |
There was a problem hiding this comment.
We shouldn't be using the regex to determine the environment. It's not reliable.
UI should read this info from the cluster config map.
example: https://github.com/redhat-appstudio/infra-deployments/pull/5168/files#diff-c0903c42c468382bfdf3dd597dcb646d4fccc9e15eddc7af1ac9ec7d3bd4b065
This is the structure of the config map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.