feat(KFLUXUI-267): replace GitHub with Git #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 80.01% 80.15% +0.13%
==========================================
Files 569 569
Lines 21380 21391 +11
Branches 5036 5041 +5
==========================================
+ Hits 17108 17146 +38
+ Misses 4248 4221 -27
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/ok-to-test |
| @@ -34,7 +34,7 @@ export class IntegrationTestsTabPage { | |||
| ) { | |||
| this.verifySaveChangesIsDisabled(); | |||
| UIhelper.inputValueInTextBoxByLabelName('Integration test name', integrationTestName); | |||
| UIhelper.inputValueInTextBoxByLabelName('GitHub URL', githubURL); | |||
| UIhelper.inputValueInTextBoxByLabelName('Git URL', githubURL); | |||
There was a problem hiding this comment.
I think variable should be renamed as well.
| @@ -52,7 +52,7 @@ export class IntegrationTestsTabPage { | |||
| this.verifySaveChangesIsDisabled(); | |||
|
|
|||
| if (githubURL) { | |||
| UIhelper.inputValueInTextBoxByLabelName('GitHub URL', githubURL); | |||
| UIhelper.inputValueInTextBoxByLabelName('Git URL', githubURL); | |||
|
LGTM |
|
/retest |
|
/test |
|
/retest |
sahil143
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace GitHub mentions with Git - part2