Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add subprotocol for logs websocket #80

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

sahil143
Copy link
Collaborator

Add missing prefix and subprotocol for the logs WebSocket

image

@sahil143
Copy link
Collaborator Author

/retest

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (b5460e5) to head (f16afa6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/k8s/k8s-utils.ts 50.00% 2 Missing ⚠️
.../shared/components/pipeline-run-logs/logs/Logs.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   80.09%   80.11%   +0.01%     
==========================================
  Files         570      570              
  Lines       21443    21445       +2     
  Branches     5307     5308       +1     
==========================================
+ Hits        17175    17180       +5     
+ Misses       4243     4240       -3     
  Partials       25       25              
Flag Coverage Δ
unittests 80.11% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gbenhaim
gbenhaim previously approved these changes Jan 15, 2025
@sahil143
Copy link
Collaborator Author

/retest

@sahil143
Copy link
Collaborator Author

/retest

1 similar comment
@sahil143
Copy link
Collaborator Author

/retest

@sahil143
Copy link
Collaborator Author

/retest

@gbenhaim
Copy link
Member

/test

@sahil143 sahil143 merged commit e47e5f9 into konflux-ci:main Jan 16, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants