-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(KFLUXVNGD-167): remove kube-rbac-proxy #153
Merged
yftacherzog
merged 1 commit into
konflux-ci:main
from
yftacherzog:KFLUXVNGD-167-remove-rbac-proxy
Jan 21, 2025
Merged
chore(KFLUXVNGD-167): remove kube-rbac-proxy #153
yftacherzog
merged 1 commit into
konflux-ci:main
from
yftacherzog:KFLUXVNGD-167-remove-rbac-proxy
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yftacherzog
force-pushed
the
KFLUXVNGD-167-remove-rbac-proxy
branch
2 times, most recently
from
January 15, 2025 14:57
dc86edb
to
a3d02f0
Compare
/retest |
yftacherzog
force-pushed
the
KFLUXVNGD-167-remove-rbac-proxy
branch
18 times, most recently
from
January 16, 2025 10:49
7ae1469
to
7614438
Compare
/retest |
Replace kube-rbac-proxy per kubernetes-sigs/kubebuilder#3907 Signed-off-by: Yftach Herzog <yherzog@redhat.com>
yftacherzog
force-pushed
the
KFLUXVNGD-167-remove-rbac-proxy
branch
from
January 19, 2025 14:09
7614438
to
7aae67e
Compare
ifireball
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
avi-biton
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
yftacherzog
added a commit
to yftacherzog/infra-deployments
that referenced
this pull request
Jan 21, 2025
Upgrade project-controller config in production to include changes from konflux-ci/project-controller#153 Signed-off-by: Yftach Herzog <yherzog@redhat.com>
yftacherzog
added a commit
to redhat-appstudio/infra-deployments
that referenced
this pull request
Jan 21, 2025
Upgrade project-controller config in production to include changes from konflux-ci/project-controller#153 Signed-off-by: Yftach Herzog <yherzog@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace kube-rbac-proxy per
kubernetes-sigs/kubebuilder#3907