Increase internal-request timeout to match #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TIMEOUT value here is the time that the parent release pipeline will wait for the internal request to finish, and the other timeouts are the timeouts applied to the child internalrequest pipeline.
If these are unequal, things don't make sense. We had a case today where an internalrequest pipeline took 20m. It succeeded in the end, but only after the parent release pipeline had given up on it. This can cause a thundering herd problem in the downstream cluster where internal requests pipelines execute, when parent pipelines retry and stack up more downstream internalrequests that end up going unused.