[숫자 야구] 이새힘 미션 제출합니다. #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 문자열 입력시 숫자 파싱 - 파싱된 숫자를 3개의 숫자 파싱 - 파싱된 숫자로 야구 반환 - 숫자로 파싱 불가능한 문자열 예외처리
- 스트라이크 판단 - 볼 판단 - 낫싱 판단
- 스트라이크 판단 메서드 - 볼 판단 메서드 - 낫싱 판단 메서드 - 정답 판단 메서드
- 시작 메시지 출력 - endFlag 초기화 - 정답 숫자배열(computer) 생성 - 판정 유틸 초기화
- 숫자입력 - 판정 - 출력
jiggyjiggy
reviewed
Nov 26, 2022
Comment on lines
+23
to
+41
| private int getStrike(List<Integer> userNumbers, List<Integer> computerNumbers) { | ||
| int result = 0; | ||
| for (int i =0; i<userNumbers.size(); i++) { | ||
| if (userNumbers.get(i)==computerNumbers.get(i)) { | ||
| result ++; | ||
| } | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| private int getBall(List<Integer> userNumbers, List<Integer> computerNumbers) { | ||
| int result = 0; | ||
| for (int userNumber : userNumbers) { | ||
| if (computerNumbers.contains(userNumber)) { | ||
| result ++; | ||
| } | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
getter setter의 네이밍는 객체 외부에서 요청하는 형식일때 쓰는게 좋아보입니다
jiggyjiggy
reviewed
Nov 26, 2022
Comment on lines
+17
to
+22
| public boolean isHomerun() { | ||
| if(strike==3) { | ||
| homerun = true; | ||
| } | ||
| return homerun; | ||
| } |
jiggyjiggy
reviewed
Nov 26, 2022
|
|
||
| private void playRound() { | ||
| Baseball userBaseball = userInput.askInputBaseball(); | ||
| JudgementType judgement = baseballJudge.judgement(userBaseball); |
There was a problem hiding this comment.
judgement의 메소드명은 동사형으로 시작하시는게 좋아보입니다
khyojun
reviewed
Nov 26, 2022
| BaseballJudge baseballJudge; | ||
| NumberGenerator numberGenerator; | ||
| InputView userInput; | ||
| Boolean endFlag; |
There was a problem hiding this comment.
되도록이면 private 붙여서 하시는게 좋은 거 같아요 3주차의 피드백 메일에 나와있습니다!
jiggyjiggy
reviewed
Nov 26, 2022
| return result; | ||
| } | ||
|
|
||
| public boolean checkAnswer(JudgementType judgement) { |
There was a problem hiding this comment.
check answer 라고 네이밍하셨는데 메소드명만 보고는 의미를 모르겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.