Fixes column matching on first field #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add column method
Allows footer rows to be skipped
Adds translations and improves layout
Defaults skipFooterCount to 1
Allows additional column matches
Update HasFieldLabel.php
…s-to-action Adds skipHeader and skipFooter methods
Improves success message
Fixes additional column match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently the first field can never be matched due to array_search returning 0 as the key which is then interpreted as falsish. This is mentioned in the PR that added this feature.
This PR changes the check from
!=to!==so that the first array key of 0 isn’t interpreted as false.Types of changes
Checklist
Further comments