All pending dacite PRs #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dict assigned with None value
Reproducible build fails if the file is encoded differently depending on the current locale settings when reading README.md.
test for type_hook with initVar added
added tests for type hinting with generic collections
- Remove unused type: ignore. - Remove asterisk import and add `__all__` with all exported names, to pass with the `no_explicit_reexport` mypy flag. - Add various mypy config for developer ergonomics (prettier errors, printing error codes, warning about unused config, ignores and casts etc). Kept `warn_return_any = False` in `dacite.types` for now since there would have to be a lot of ignores/casts otherwise.
Also add a test to help ensure that type_hooks continues to work with a very general Mapping implementation.
allow `is_instance` checks for arbitrary generic types add test for `npt.NDArray` handling
mark 2 tests with `init_var_type_support`
|
@idanmiara thank you - I'm on it, but I have to review all PR/issues first, so I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @konradhalas,
I've opened this PR in case you wanted to merge this to the official release.
idanmiara#1
Thanks :)