Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Remove placeholders from descriptions #53

Merged
merged 3 commits into from
Jan 10, 2024
Merged

🐛 Remove placeholders from descriptions #53

merged 3 commits into from
Jan 10, 2024

Conversation

fabianvf
Copy link
Contributor

@fabianvf fabianvf commented Jan 9, 2024

No description provided.

@fabianvf
🐛 Remove placeholders from descriptions
03ef1a6 
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
@fabianvf fabianvf added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Jan 9, 2024
jmle
jmle requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done some modifications that I think improve a bit the descriptions, mostly shortening them (suggestions and references to links are usually placed in the message)

default/generated/camel3/18-java-generic-information.windup.yaml Outdated Show resolved Hide resolved
default/generated/camel3/18-java-generic-information.windup.yaml Outdated Show resolved Hide resolved
default/generated/camel3/18-java-generic-information.windup.yaml Outdated Show resolved Hide resolved
...lt/generated/camel3/19-java-multiple-camelcontexts-per-application-not-supported.windup.yaml Outdated Show resolved Hide resolved
default/generated/camel3/22-xml-moved-components.windup.yaml Outdated Show resolved Hide resolved
default/generated/openjdk17/149-removed-classes.windup.yaml Outdated Show resolved Hide resolved
default/generated/openjdk17/151-security-manager-deprecation.windup.yaml Outdated Show resolved Hide resolved
default/generated/openjdk17/151-security-manager-deprecation.windup.yaml Outdated Show resolved Hide resolved
default/generated/openjdk21/08-utf-8-by-default.windup.yaml Outdated Show resolved Hide resolved
default/generated/openjdk21/08-utf-8-by-default.windup.yaml Outdated Show resolved Hide resolved
@rromannissen
Copy link

I have done some modifications that I think improve a bit the descriptions, mostly shortening them (suggestions and references to links are usually placed in the message)

+1 to all @jmle suggestions!

@jmle
Improve phrasing of some descriptions
f330e13 
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@pranavgaikwad
Update default/generated/eap6/33-jboss-eap5-java.windup.yaml
c325829 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@jmle jmle merged commit 39b8c33 into konveyor:main Jan 10, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
@fabianvf @jmle
@pranavgaikwad @web-flow
🐛 Remove placeholders from descriptions (#53)
208cd74 
* 🐛 Remove placeholders from descriptions

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>

* Improve phrasing of some descriptions

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>

* Update default/generated/eap6/33-jboss-eap5-java.windup.yaml

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

---------

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad added a commit that referenced this pull request Jan 10, 2024
@github-actions @fabianvf
@jmle @pranavgaikwad
🐛 Remove placeholders from descriptions (#53) (#54)
2e3cda1 
* 🐛 Remove placeholders from descriptions



* Improve phrasing of some descriptions



* Update default/generated/eap6/33-jboss-eap5-java.windup.yaml



---------

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Fabian von Feilitzsch <fabian@fabianism.us>
Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmle jmle jmle requested changes

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabianvf @rromannissen @jmle @pranavgaikwad