Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using performRowActionByIcon for editing archetype #1235

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Using performRowActionByIcon for editing archetype #1235

merged 1 commit into from
Oct 11, 2024

Conversation

Shevijacobson
Copy link
Contributor

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 6, 2024

Hi @Shevijacobson. Thanks for your PR.

I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shevijacobson Shevijacobson force-pushed the update-arch-edit branch 2 times, most recently from 08c5e13 to c6b1afc Compare October 6, 2024 07:25
@Shevijacobson
Using performRowActionByIcon for editing archetype
4734ac0 
Signed-off-by: shevijacobson <shevijacob@gmail.com>
@Shevijacobson Shevijacobson marked this pull request as ready for review October 6, 2024 12:05
@mguetta1
Copy link
Contributor

mguetta1 commented Oct 6, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2024
mguetta1
mguetta1 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1
Copy link
Contributor

mguetta1 commented Oct 6, 2024

image

abrugaro
abrugaro approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @Shevijacobson !!

@abrugaro abrugaro merged commit 7aaba72 into konveyor:main Oct 11, 2024
8 of 9 checks passed
EstyBiton pushed a commit to EstyBiton/tackle-ui-tests that referenced this pull request Oct 27, 2024
@Shevijacobson @EstyBiton
use performRowActionByIcon for editing archetype (konveyor#1235)
8f6114f 
Signed-off-by: shevijacobson <shevijacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrugaro abrugaro abrugaro approved these changes

@mguetta1 mguetta1 mguetta1 approved these changes

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shevijacobson @mguetta1 @abrugaro