Skip to content

Commit

Permalink
Rename message key and fix translation usage for job function deletion
Browse files Browse the repository at this point in the history
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
  • Loading branch information
DvoraShechter1 committed Sep 26, 2024
1 parent a901283 commit 4b27160
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion client/public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
"message": {
"applicationsBulkDelete": "The selected application(s) will be deleted.",
"delete": "This action cannot be undone.",
"deleteTooltipMessage": "Cannot remove a Job function associated with stakeholder(s)",
"discardAssessment": "The assessment(s) for <1>{{applicationName}}</1> will be discarded. Do you wish to continue?",
"discardReview": "The review for <1>{{applicationName}}</1> will be discarded. Do you wish to continue?",
"leavePage": "Are you sure you want to leave this page? Be sure to save your changes, or they will be lost.",
Expand Down Expand Up @@ -181,6 +180,7 @@
"blockedDeleteApplication": "Cannot delete {{what}} because it is associated with an application.",
"blockedDeleteTarget": "Cannot delete {{what}} because it is associated with a target.",
"defaultBlockedDelete": "Cannot delete {{what}} because it is associated with another object.",
"cannotDeleteJobFunctionWithStakeholders": "Cannot remove a Job function associated with stakeholder(s)",
"cannotDeleteApplicationsAssignedToMigrationWave": "Cannot delete applications that are assigned to a migration wave.",
"cannotDeleteNonEmptyTagCategory": "Cannot delete a tag category that contains tags.",
"continueConfirmation": "Yes, continue",
Expand Down
1 change: 0 additions & 1 deletion client/public/locales/es/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"message": {
"applicationsBulkDelete": "Se eliminarán las aplicacione(s) seleccionadas.",
"delete": "Esta acción no puede ser revertida.",
"deleteTooltipMessage": "No se puede eliminar una función de trabajo asociada con partes interesadas",
"discardAssessment": "La evaluación para <1>{{applicationName}}</1> será descartada, también los resultados de la revisión. ¿Deseas continuar?",
"leavePage": "¿Estás seguro de querer salir de esta página? Asegúrate de guardar tus cambios o estos se perderán.",
"pageError": "¡Ups! Algo salió mal.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ export const JobFunctions: React.FC = () => {
</Td>
<ControlTableActionButtons
isDeleteEnabled={!!jobFunction.stakeholders}
deleteTooltipMessage={t("deleteTooltipMessage")}
deleteTooltipMessage={t(
"message.cannotDeleteJobFunctionWithStakeholders"
)}
onEdit={() => setCreateUpdateModalState(jobFunction)}
onDelete={() => deleteRow(jobFunction)}
/>
Expand Down

0 comments on commit 4b27160

Please sign in to comment.