-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add edit icon with ActionColumns property in the Archetypes table #2098
Conversation
a0d63b6
to
b14dceb
Compare
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
18463e3
to
abcc5ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
==========================================
+ Coverage 39.20% 41.97% +2.77%
==========================================
Files 146 175 +29
Lines 4857 5629 +772
Branches 1164 1415 +251
==========================================
+ Hits 1904 2363 +459
- Misses 2939 3145 +206
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
5b2c945
to
c9dd6fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! 2 minor comments:
- it would be nice to rephrase PR title to better reflect the change - it will be used as git commit title and stay in the repo history forever:)
- if the change has some visual effect it's also nice to add before/after screenshots in a separate
commitcomment.
@mguetta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
An issue has been opened to address the above: #2111 |
Changes Made:
Removed the edit action from the ActionsColumn.
Added a dedicated edit icon outside the ActionsColumn, providing a clearer and more focused user interface.
Part of #1318
Before the change:
After the change: