Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Reallocate col spacing & add overflow style for status #1756

Closed
wants to merge 1 commit into from

Conversation

ibolton336
Copy link
Member

Closes: #1753

@ibolton336 ibolton336 force-pushed the missing-overflow branch 4 times, most recently from 817538b to bd152a6 Compare March 8, 2024 20:37
Signed-off-by: Ian Bolton <ibolton@redhat.com>
@rszwajko
Copy link
Collaborator

The text can get truncated too much i.e. to one letter:
image
At this point we would need a tooltip not to loose information - ideally visible only when the text overflows. The default table implementation works well also for complex nodes but ...requires overflow. It would work for previous code (without fix) i.e.
image

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on Radek's comment and the slack chat -

The containing Flex in IconedStatus is set to "nowrap". Maybe for the smaller size breakpoints (the sm and md sizes maybe?) it can be changed to the normal "wrap". That would let the icons and label wrap in their container.

For the label FlexItem, it may be worth setting a min-width so at least a few letters will always be visible. The ch unit is "Relative to the width of "0" (zero)" (I did not know that until just now). So maybe a min-width: 10ch or similar?

@ibolton336 ibolton336 marked this pull request as draft March 13, 2024 01:37
@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Mar 21, 2024
@ibolton336 ibolton336 added this to the v0.3.1 milestone Mar 21, 2024
@sjd78 sjd78 closed this Apr 3, 2024
@sjd78 sjd78 reopened this Apr 3, 2024
@sjd78 sjd78 removed this from the v0.3.1 milestone Apr 5, 2024
@ibolton336 ibolton336 closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Overflow missing on application table status
3 participants