-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add app details: Include a list of targets the project was checked against #2140
base: main
Are you sure you want to change the base?
Conversation
…ainst Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
…ainst Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Signed-off-by: sarinailinger <sn0533129699@gmail.com>
Signed-off-by: DvoraShechter1 <168653685+DvoraShechter1@users.noreply.github.com>
Translation support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 39.20% 41.98% +2.78%
==========================================
Files 146 175 +29
Lines 4857 5630 +773
Branches 1164 1395 +231
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3145 +206
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the basics are there. Need to update the render parts a bit.
Does it make more sense to put the Targets on the Reports tab? That is the tab where the results are available to download.
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
…attribute to mapped components and 'Not available' message for empty analysis. Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Add iInformation in the app details:
list of targets that the project was checked against
part 1 from #2012