Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add app details: Include a list of targets the project was checked against #2140

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DvoraShechter1
Copy link
Contributor

Add iInformation in the app details:
list of targets that the project was checked against
part 1 from #2012

…ainst

Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
DvoraShechter1 and others added 5 commits October 28, 2024 16:39
…ainst

Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Signed-off-by: sarinailinger <sn0533129699@gmail.com>
Signed-off-by: DvoraShechter1 <168653685+DvoraShechter1@users.noreply.github.com>
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (b654645) to head (826ca64).
Report is 241 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
+ Coverage   39.20%   41.98%   +2.78%     
==========================================
  Files         146      175      +29     
  Lines        4857     5630     +773     
  Branches     1164     1395     +231     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3145     +206     
- Partials       14      121     +107     
Flag Coverage Δ
client 41.98% <ø> (+2.78%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the basics are there. Need to update the render parts a bit.

Does it make more sense to put the Targets on the Reports tab? That is the tab where the results are available to download.

…attribute to mapped components and 'Not available' message for empty analysis.

Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants