Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct abnormal behavior of the list button and menu query in the ProductForm #644

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

sebai-dhia
Copy link
Contributor

he issue is caused by event interference, which triggers a listener before the pop-up is displayed. To correct this, it is necessary to release the current thread for a few milliseconds to allow events to synchronize properly.

On the other hand, the display issue was caused by the visible parameter, which determines the number of lines to display. If it is less than 10, it adds a scroll to the pop-up. Therefore, I have set this parameter to 500 to maintain consistent behavior across similar projects (this parameter should ideally be managed automatically for lines greater than 10).

To address the two abnormal behaviors described in this task, we:

Add a Thread.sleep(50) // Pause for 50 milliseconds to correct the behavior of the List button.
Change the value of visible from 1 to 500 for the ProductForm.

@sebai-dhia sebai-dhia requested a review from mgrati November 1, 2024 14:22
@mgrati mgrati merged commit 3609a71 into master Nov 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants