Skip to content

Commit

Permalink
Adding more description
Browse files Browse the repository at this point in the history
  • Loading branch information
kopiro committed Oct 3, 2024
1 parent 3685425 commit 524bdd9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
"copy"
]
},
"description": "Set the codec used for encoding video sent to HomeKit, must be H.264-based. You can change to a hardware accelerated video codec with this option, if one is available. By default, we set 'copy' to avoid any video processing happening on the Homebridge server, but this also means possibly sending more bits to your device than necessary. Also, consider that setting 'copy' will discard all of the 'max' settings above."
"description": "Set the codec used for encoding video sent to HomeKit, must be H.264-based. You can change to a hardware accelerated video codec with this option, if one is available. By default, we set 'copy' to avoid any video processing happening on the Homebridge server and disregarding any max values set above, but this also means possibly sending more video data to your devices than necessary, and some Homekit clients may not like not receiving the resolutions/fps they asked for. If you select a custom codec and your ffmpeg process is crashing, it most likely can't handle the video codec you've chosen."
}
}
}
Expand Down
7 changes: 0 additions & 7 deletions src/cameraAccessory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,6 @@ export class CameraAccessory {
);

const vcodec = this.config.videoCodec ?? "copy";

if (vcodec === "copy") {
this.log.warn(
"You're using the default 'copy' codec. This means that any maximum resolution, FPS, or bitrate you set will be ignored, and you're pushing the camera's native stream directly to HomeKit. This can cause issues if the camera's native stream is not compatible with HomeKit. If you're experiencing issues, try setting a custom codec."
);
}

const config: VideoConfig = {
audio: true, // Set audio as true as most of TAPO cameras have audio
vcodec: vcodec,
Expand Down

0 comments on commit 524bdd9

Please sign in to comment.