Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bytedance IconPack with 10,632 Icons (2658 unique icons in 4 weights) #158

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

leewyatt
Copy link
Contributor

Hello,

I've added the Bytedance IconPack (https://github.com/bytedance/iconpark) to the project. This IconPack contains a total of 2,658 unique icons, each available in 4 different weights, leading to a grand total of 10,632 icons.

Details:

  • Source: Bytedance IconPack
  • Unique Icons: 2,658
  • Total Icons (considering 4 weights): 10,632

This PR targets the master branch. I'm not sure if there's a need for modifications with respect to the java1.8 branch, so please let me know if such changes are required.

If there are any concerns or if further communication is needed, please don't hesitate to contact me.

Thank you for considering this contribution.

Best regards,
Lee Wyatt

@leewyatt
Copy link
Contributor Author

image
image

@leewyatt
Copy link
Contributor Author

image
The copyright information for the Handler and Provider classes was copied from another piece of code. I'm uncertain if this approach is appropriate.

@aalmiray
Copy link
Collaborator

Thank you for this amazing contribution. But before I can merge it, do you know what license governs these icons? We can only use icons whose license allow free redistribution.

@leewyatt
Copy link
Contributor Author

leewyatt commented Aug 20, 2023

These SVG icons are sourced from an open-source project called Bytedance IconPack, which is under the Apache-2.0 license. However, the SVG icons couldn't be directly converted to font files. I wrote a script to process these SVGs, and then used the online tool at https://icomoon.io/ to convert the processed SVGs into font files. I have open-sourced the processed SVGs. (https://github.com/leewyatt/IconPark)
You might also want to review these sites:

  1. https://iconpark.oceanengine.com/home
  2. https://iconpark.oceanengine.com/official
  3. https://github.com/bytedance/iconpark

image

@aalmiray aalmiray added this to the 12.4.0 milestone Nov 30, 2023
@aalmiray aalmiray merged commit 3de249e into kordamp:master Nov 30, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants