Prevent updating position without target #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scrolling a list on mobile, Slip attempts to update positions even though no element is grabbed. That's problematic, as we have no target object, so let's just not do that.
|
It does seem hide the error rather than fix the root cause. If there's no target, then the library shouldn't be in state of dragging a target. |
|
You're absolutely right, and I agree. As I just |
|
On second thought, I saw this issue first on Android actually. And I know events are fired as they should there. |
|
I have same problem in Chrome for Android. What is the status of this? |
kornelski
added a commit
that referenced
this pull request
Feb 27, 2015
Prevent updating position without target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrolling a list on mobile, Slip attempts to update positions even
though no element is grabbed. That's problematic, as we have no target
object, so let's just not do that. This fixes #32 . No hard feelings if you deem this solution too hacky, and don't accept it. There might be more appropriate places to stop this behaviour, but this works perfectly and doesn't break anything in my experience.