merge_release_5-4#88
Open
kosmicunifr wants to merge 414 commits intokosmicunifr:release_5-4-kosmicfrom
Open
Conversation
…eyboard / tabbing
- supporton result outputscreen - don't show page content for autosave - avoid code duplication of getSolutionOutput - support cloze questions (other question types can be supported similar)
Commit 8c99d39 added function countWords to class assTextQuestion, the following commit d640122 removed its usage again, but not the function itself. Since then, it has been unused code; remove it. See <https://mantis.ilias.de/view.php?id=28561> for the background.
Test: Fix Mantis issue 26088 (Part III)
… columns, thanks to fneumann for the pr
…into release_5-4
Checks for existence of $tree in container in the initialisation
The FormulaQuestion throws an uncatched error (division by 0) in case "No Restrictions" are set for the "Result Type Selection". This was fixed for "Fraction" and "Coprime Fraction" in commit b9b74b6 and this solution is now extended to "No Restrictions". This fix was adjusted though, because in case of a ilMathDivisionByZeroException the users result was set to "0" which might be a correct answer. Now the division by 0 lets the check function return false, except in case the formula also threw this exception. Mantis-Ticket: 0029692
Up until now ILIAS supported float tolerances in the Formula Question, but the GUI cut off all decimal places and with subsequent changes to the question could lead to a unintendet change of the tolerance. Mantis-Ticket: 0028467
Release 5.4 Bug Fixes Formula Question
Make initLogging properly signal to its caller when setting up logging fails. Its calling code, in handleRequest, is already prepared to handle errors from logging inititalization. It makes not much sense to always return “no error”. This change structures the method like the others in the ilServer class.
Use the exit value of the JVM process to signal success or failure to the caller. It does not matter if System.exit throws a Throwable as a result of e.g. super strict security rules; but for the usual case that it does not, callers can easily react to errors.
…_5-4 Improve error propagation in ilServer (release_5-4)
When code was moved from the test GUI object in 27bebea, a necessary adaption of the target class was missed (`$this` now points to another class). Fixes <https://mantis.ilias.de/view.php?id=28489>. Fixes <https://mantis.ilias.de/view.php?id=31297>.
28790, 26497, 25648 Rename showMoveIntoObjectTree to showPasteTree
…ffset) with session title in "Learning Progress User Detail View"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.