perf config: fix bug in parsing 'man.<tool>.*' config#135
Open
lsahn-gh wants to merge 1 commit intokosslab-kr:masterfrom
lsahn-gh:develop
Open
perf config: fix bug in parsing 'man.<tool>.*' config#135lsahn-gh wants to merge 1 commit intokosslab-kr:masterfrom lsahn-gh:develop
lsahn-gh wants to merge 1 commit intokosslab-kr:masterfrom
lsahn-gh:develop
Conversation
To add new man viewer, configs like 'man.<tool>.cmd',
'man.<tool>.path' can be set into config file (~/.perfconfig).
But parsing config file is stopped because the config variable
contains '.' character i.e.
If setting 'man.xman.cmd' into config file,
[man]
gman.cmd = gman
when launching perf an error message is printed like below.
Fatal: bad config file line 11 in /home/hja/.perfconfig
So modify iskeychar() function to decide '.' character
as key character parsing config file.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Yi Soo, An <yisooan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add new man viewer, configs like 'man..cmd',
'man..path' can be set into config file (~/.perfconfig).
But parsing config file is stopped because the config variable
contains '.' character i.e.
If setting 'man.xman.cmd' into config file,
when launching perf an error message is printed like below.
So modify iskeychar() function to decide '.' character
as key character parsing config file.
Acked-by: Namhyung Kim namhyung@kernel.org
Cc: Jiri Olsa jolsa@kernel.org
Signed-off-by: Yi Soo, An yisooan@gmail.com