perf config: Fix a bug about permission checking state of config file#149
Open
wookje wants to merge 1 commit intokosslab-kr:masterfrom
Open
perf config: Fix a bug about permission checking state of config file#149wookje wants to merge 1 commit intokosslab-kr:masterfrom
wookje wants to merge 1 commit intokosslab-kr:masterfrom
Conversation
perf_config_set__init() check state of user config file before opening it. But there is a bug when checking uid and euid of current user. Although current user have superuser permission, a error occurs as below. Before: user01@localhost:~$ ls -l ~/.perfconfig -rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig user01@localhost:~/linux-perf/tools/perf/util$ sudo perf config --list Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it. Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it. So, Fix it allowing a user who have superuser permission to open user config file. After: user01@localhost:~$ ls -l ~/.perfconfig -rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig user01@localhost:~$ sudo perf config --list annotate.hide_src_code=false report.queue-size=0 tui.report=on colors.top=red, default Cc: Taeung Song <taeung@kosslab.kr> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Wookje Kwon <aweee0@gmail.com>
Collaborator
|
How did you amend it? Why would you be possible without root authority? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf_config_set__init() check state of user config file
before opening it. But there is a bug when checking uid
and euid of current user. Although current user have superuser
permission, a error occurs as below.
Before:
user01@localhost:~$ ls -l ~/.perfconfig
-rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig
user01@localhost:~/linux-perf/tools/perf/util$ sudo perf config --list
Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it.
Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it.
So, Fix it allowing a user who have superuser permission
to open user config file.
After:
user01@localhost:~$ ls -l ~/.perfconfig
-rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig
user01@localhost:~$ sudo perf config --list
annotate.hide_src_code=false
report.queue-size=0
tui.report=on
colors.top=red, default
Cc: Taeung Song taeung@kosslab.kr
Cc: Namhyung Kim namhyung@kernel.org
Cc: Jiri Olsa jolsa@kernel.org
Signed-off-by: Wookje Kwon aweee0@gmail.com