Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow readonly array in where #109

Open
wants to merge 1 commit into
base: v8
Choose a base branch
from

Conversation

SrBrahma
Copy link

@SrBrahma SrBrahma commented Jan 7, 2022

Allows

const array = ['a', 'b'] as const;
query(doc, [where('key', 'in', array)])

Without this PR, an error is throw:

No overload matches this call.
  The last overload gave the following error.
    Argument of type 'string' is not assignable to parameter of type '[keyof DbOrder, string | number | symbol, string | number | symbol, string | number | symbol, string | number | symbol, string | number | symbol, string | number | symbol, string | ... 1 more ... | symbol, string | ... 1 more ... | symbol, string | ... 1 more ... | symbol]'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant