Cleaning up IDE version differentiated files where files are identical #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dropping a lot of old versions in 48daacf we can commonize a lot of code that is identical across remaining IDE versions.
|
If the plugin.xml is always the same its fine to share too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After dropping a lot of old versions in 48daacf we can commonize a lot of code that is identical across remaining IDE versions.
I used
diff -rq src/IC-223 src/IC-231and compared 223 to every other version. Turns out all was identical, exceptfiles.ktwhich is differing for IC242, so I let that file remain in the individual source dirs.I also moved the plugin.xml into the common source set. Do you think that's alright to do?