Add float family types to ValueTYpe

kou · Aug 2, 2024 · 2c60782 · 2c60782
1 parent e935d66
commit 2c60782
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cpp/src/arrow/array/statistics.h b/cpp/src/arrow/array/statistics.h
@@ -23,6 +23,7 @@
 #include <string_view>
 #include <variant>
 
+#include "arrow/util/float16.h"
 #include "arrow/util/visibility.h"
 
 namespace arrow {
@@ -35,7 +36,7 @@ namespace arrow {
 struct ARROW_EXPORT ArrayStatistics {
   using ValueType =
       std::variant<bool, int8_t, uint8_t, int16_t, uint16_t, int32_t, uint32_t, int64_t,
-                   uint64_t, std::string, std::string_view>;
+                   uint64_t, util::Float16, float, double, std::string, std::string_view>;
 
   ArrayStatistics() = default;
   ~ArrayStatistics() = default;

diff --git a/cpp/src/arrow/array/statistics_test.cc b/cpp/src/arrow/array/statistics_test.cc
@@ -89,9 +89,9 @@ TEST(ArrayStatisticsTest, TestEquality) {
   statistics2.is_min_exact = false;
   ASSERT_EQ(statistics1, statistics2);
 
-  statistics1.max = static_cast<int64_t>(-255);
+  statistics1.max = arrow::util::Float16(-29);
   ASSERT_NE(statistics1, statistics2);
-  statistics2.max = static_cast<int64_t>(-255);
+  statistics2.max = arrow::util::Float16(-29);
   ASSERT_EQ(statistics1, statistics2);
 
   statistics1.is_max_exact = true;