Use interface library

kou · Jul 4, 2024 · 2f5efaa · 2f5efaa
1 parent 0f8cd28
commit 2f5efaa
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -4592,17 +4592,19 @@ function(build_orc)
 
   fetchcontent_makeavailable(orc)
   if(CMAKE_VERSION VERSION_LESS 3.28)
+    message("XXX: ${orc_SOURCE_DIR}")
+    file(MAKE_DIRECTORY ${orc_SOURCE_DIR})
     set_property(DIRECTORY ${orc_SOURCE_DIR} PROPERTY EXCLUDE_FROM_ALL TRUE)
   endif()
 
   set(ORC_VENDORED
       TRUE
       PARENT_SCOPE)
 
-  target_include_directories(orc INTERFACE "${orc_BINARY_DIR}/c++/include"
-                                           "${orc_SOURCE_DIR}/c++/include")
-
-  add_library(orc::orc ALIAS orc)
+  add_library(orc::orc INTERFACE)
+  target_link_libraries(orc::orc INTERFACE orc)
+  target_include_directories(orc::orc INTERFACE "${orc_BINARY_DIR}/c++/include"
+                                                "${orc_SOURCE_DIR}/c++/include")
 
   list(APPEND ARROW_BUNDLED_STATIC_LIBS orc)
   set(ARROW_BUNDLED_STATIC_LIBS