Skip to content

Commit

Permalink
apacheGH-43805: [C++] Enable filesystem automatically when one of ARR…
Browse files Browse the repository at this point in the history
…OW_{AZURE,GCS,HDFS,S3}=ON is specified (apache#43806)

### Rationale for this change

`ARROW_{AZURE,GCS,HDFS,S3}=ON` are meaningful only when filesystem is enabled. If the user specified one of them, we can assume that the user wants to enable filesystem.

### What changes are included in this PR?

Enable `ARROW_FILESYSTEM` when one of `ARROW_{AZURE,GCS,HDFS,S3}=ON` are specified.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

`ARROW_FILESYSTEM` is enabled automatically with one of `ARROW_{AZURE,GCS,HDFS,S3}=ON`.
* GitHub Issue: apache#43805

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
  • Loading branch information
kou committed Aug 27, 2024
1 parent ce1e724 commit 75ca5b3
Showing 1 changed file with 18 additions and 4 deletions.
22 changes: 18 additions & 4 deletions cpp/cmake_modules/DefineOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,10 @@ takes precedence over ccache if a storage backend is configured" ON)
ARROW_IPC)

define_option(ARROW_AZURE
"Build Arrow with Azure support (requires the Azure SDK for C++)" OFF)
"Build Arrow with Azure support (requires the Azure SDK for C++)"
OFF
DEPENDS
ARROW_FILESYSTEM)

define_option(ARROW_BUILD_UTILITIES "Build Arrow commandline utilities" OFF)

Expand Down Expand Up @@ -346,9 +349,16 @@ takes precedence over ccache if a storage backend is configured" ON)
ARROW_WITH_UTF8PROC)

define_option(ARROW_GCS
"Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
"Build Arrow with GCS support (requires the GCloud SDK for C++)"
OFF
DEPENDS
ARROW_FILESYSTEM)

define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)
define_option(ARROW_HDFS
"Build the Arrow HDFS bridge"
OFF
DEPENDS
ARROW_FILESYSTEM)

define_option(ARROW_IPC "Build the Arrow IPC extensions" ON)

Expand Down Expand Up @@ -398,7 +408,11 @@ takes precedence over ccache if a storage backend is configured" ON)
ARROW_HDFS
ARROW_JSON)

define_option(ARROW_S3 "Build Arrow with S3 support (requires the AWS SDK for C++)" OFF)
define_option(ARROW_S3
"Build Arrow with S3 support (requires the AWS SDK for C++)"
OFF
DEPENDS
ARROW_FILESYSTEM)

define_option(ARROW_SKYHOOK
"Build the Skyhook libraries"
Expand Down

0 comments on commit 75ca5b3

Please sign in to comment.