Remove expired checks

kou · Jun 22, 2023 · b9abe3a · b9abe3a
1 parent 447ae24
commit b9abe3a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 56 deletions.
diff --git a/cpp/src/arrow/flight/integration_tests/test_integration.cc b/cpp/src/arrow/flight/integration_tests/test_integration.cc
@@ -638,20 +638,6 @@ class ExpirationTimeDoGetScenario : public Scenario {
         }
       }
     }
-    // Re-reads after expired
-    for (const auto& endpoint : info->endpoints()) {
-      if (!endpoint.expiration_time.has_value()) {
-        continue;
-      }
-      const auto& expiration_time = endpoint.expiration_time.value();
-      if (expiration_time > Timestamp::clock::now()) {
-        std::this_thread::sleep_for(expiration_time - Timestamp::clock::now());
-      }
-      auto reader = client->DoGet(endpoint.ticket);
-      if (reader.ok()) {
-        return Status::Invalid("Expired data shouldn't be readable");
-      }
-    }
     ARROW_ASSIGN_OR_RAISE(auto table, ConcatenateTables(tables));
 
     // Build expected table

diff --git a/go/arrow/internal/flight_integration/scenario.go b/go/arrow/internal/flight_integration/scenario.go
@@ -1010,29 +1010,6 @@ func (tester *expirationTimeDoGetScenarioTester) RunClient(addr string, opts ...
 			return rdr.Err()
 		}
 	}
-	// Re-reads after expired
-	for _, ep := range info.Endpoint {
-		if ep.ExpirationTime == nil {
-			continue
-		}
-
-		expirationTime := ep.ExpirationTime.AsTime()
-		avalilableDuration := time.Until(expirationTime)
-		if avalilableDuration > 0 {
-			time.Sleep(avalilableDuration)
-		}
-
-		stream, err := client.DoGet(ctx, ep.Ticket)
-		if err != nil {
-			return err
-		}
-
-		rdr, err := flight.NewRecordReader(stream)
-		if err == nil {
-			rdr.Release()
-			return fmt.Errorf("expired data shouldn't be readable")
-		}
-	}
 
 	// Build expected records
 	mem := memory.DefaultAllocator

diff --git a/.../src/main/java/org/apache/arrow/flight/integration/tests/ExpirationTimeDoGetScenario.java b/.../src/main/java/org/apache/arrow/flight/integration/tests/ExpirationTimeDoGetScenario.java
@@ -86,25 +86,6 @@ public void client(BufferAllocator allocator, Location location, FlightClient cl
         }
       }
 
-      // No re-read after expiration
-      for (FlightEndpoint endpoint : info.getEndpoints()) {
-        Optional<Instant> maybeExpiration = endpoint.getExpirationTime();
-        if (!maybeExpiration.isPresent()) {
-          continue;
-        }
-        Instant now = Instant.now();
-        Instant expiration = maybeExpiration.get();
-        if (expiration.isAfter(now)) {
-          Thread.sleep(ChronoUnit.MILLIS.between(now, expiration) + 1);
-        }
-        IntegrationAssertions.assertThrows(FlightRuntimeException.class, () -> {
-          try (FlightStream stream = client.getStream(endpoint.getTicket())) {
-            while (stream.next()) {
-            }
-          }
-        });
-      }
-
       // Check data
       IntegrationAssertions.assertEquals(5, batches.size());
       try (final VectorSchemaRoot root = VectorSchemaRoot.create(ExpirationTimeProducer.SCHEMA, allocator)) {