Skip to content

Commit

Permalink
Use pid() not id() for readability
Browse files Browse the repository at this point in the history
  • Loading branch information
kou committed Aug 29, 2024
1 parent f2f4858 commit c964c7c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/test_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Status TestServer::Start(const std::vector<std::string>& extra_args) {
args.insert(args.end(), extra_args.begin(), extra_args.end());
server_process_->SetArgs(args);
ARROW_RETURN_NOT_OK(server_process_->Execute());
std::cout << "Server running with pid " << server_process_->id() << std::endl;
std::cout << "Server running with pid " << server_process_->pid() << std::endl;
return Status::OK();
}

Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/testing/process.cc
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ class Process::Impl {
#endif
}

uint64_t id() {
uint64_t pid() {
if (!process_) {
return 0;
}
Expand Down Expand Up @@ -296,5 +296,5 @@ Status Process::Execute() { return impl_->Execute(); }

bool Process::IsRunning() { return impl_->IsRunning(); }

uint64_t Process::id() { return impl_->id(); }
uint64_t Process::pid() { return impl_->pid(); }
} // namespace arrow::util
2 changes: 1 addition & 1 deletion cpp/src/arrow/testing/process.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class ARROW_TESTING_EXPORT Process {
void IgnoreStderr();
Status Execute();
bool IsRunning();
uint64_t id();
uint64_t pid();

private:
class Impl;
Expand Down

0 comments on commit c964c7c

Please sign in to comment.