Skip to content

Commit

Permalink
apacheGH-42017: [CI][Python][C++] Fix utf8proc detection for wheel on…
Browse files Browse the repository at this point in the history
… Windows
  • Loading branch information
kou committed Jun 6, 2024
1 parent 9ee6ea7 commit f913cda
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cpp/cmake_modules/Findutf8proc.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if(utf8proc_FOUND)
return()
endif()

if(ARROW_PACKAGE_KIND STREQUAL "vcpkg")
if(ARROW_PACKAGE_KIND STREQUAL "vcpkg" OR VCPKG_ROOT)
set(find_package_args "")
if(utf8proc_FIND_VERSION)
list(APPEND find_package_args ${utf8proc_FIND_VERSION})
Expand Down
2 changes: 2 additions & 0 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -2820,6 +2820,8 @@ endmacro()

if(ARROW_WITH_UTF8PROC)
resolve_dependency(utf8proc
FORCE_ANY_NEWER_VERSION
TRUE
PC_PACKAGE_NAMES
libutf8proc
REQUIRED_VERSION
Expand Down
3 changes: 0 additions & 3 deletions cpp/cmake_modules/Usevcpkg.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,6 @@ set(LZ4_ROOT
CACHE STRING "")

if(CMAKE_HOST_WIN32)
set(utf8proc_MSVC_STATIC_LIB_SUFFIX
""
CACHE STRING "")
set(LZ4_MSVC_LIB_PREFIX
""
CACHE STRING "")
Expand Down

0 comments on commit f913cda

Please sign in to comment.