fix condition for typed_default (#155)

koxudaxi · Jun 19, 2020 · 2cc4d0d · 2cc4d0d
1 parent 6630985
commit 2cc4d0d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/datamodel_code_generator/parser/jsonschema.py b/datamodel_code_generator/parser/jsonschema.py
@@ -122,7 +122,7 @@ def validate_items(cls, values: Any) -> Any:
 
     @property
     def typed_default(self) -> Union[str, bool, Dict[Any, Any], None]:
-        if self.default and self.type:
+        if self.default is not None and self.type:
             type_ = self.type[0] if isinstance(self.type, list) else self.type
             return self._get_typed_default(type_, self.default)
         return None

diff --git a/tests/parser/test_jsonschema.py b/tests/parser/test_jsonschema.py
@@ -192,7 +192,9 @@ def test_parse_one_of_object(source_obj, generated_classes):
     'type_,default,expected',
     [
         ('string', 'abc', "'abc'"),
+        ('string', '', "''"),
         ('number', 123, 123),
+        ('number', 0, 0),
         ('boolean', 'true', True),
         ('boolean', 'false', False),
         ('null', 'null', None),