Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/default feature false error enum #42

Merged
merged 12 commits into from
Apr 25, 2024

Conversation

toelo3
Copy link
Collaborator

@toelo3 toelo3 commented Apr 25, 2024

Check all features for compile issues when build individually, apply fixes where needed. Also add extra step in Github Actions to check for compile errors per feature and all combinations of features

@toelo3 toelo3 linked an issue Apr 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.4%. Comparing base (df6d608) to head (6d1bd09).

Additional details and impacted files
Files Coverage Δ
dsh_sdk/src/error.rs 0.0% <ø> (ø)
dsh_sdk/src/dlq.rs 76.4% <50.0%> (+1.8%) ⬆️
dsh_sdk/src/dsh/datastream.rs 88.8% <0.0%> (ø)

@toelo3 toelo3 merged commit 7263475 into main Apr 25, 2024
8 of 9 checks passed
@toelo3 toelo3 deleted the fix/default-feature-false-error-enum branch April 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Fail to compile when default-features are off
1 participant