Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR release v0.5.0 #95

Merged
merged 24 commits into from
Jan 22, 2025
Merged

PR release v0.5.0 #95

merged 24 commits into from
Jan 22, 2025

Conversation

toelo3
Copy link
Collaborator

@toelo3 toelo3 commented Dec 19, 2024

PR for refactoring DSH SDK

toelo3 and others added 7 commits December 17, 2024 16:20
* Refactor to desired structure

* fix metric test

* Update branch.yaml

* cargo fmt

* fix feature flags

* simplify feature flags for now

* add env_dependency
* Add schema store api
only on PR

* Add DshKafkaConfig trait and update DLQ

* Update readme and minor bugs
* small fix in readme

* update existing examples

* Update readme/changelog/security

* update examples

* align methods with RDkafka

* cargo fmt

* Remove certificate flag

* improve schema store api (WIP)

* improve schema store
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 86.65208% with 671 lines in your changes missing coverage. Please review.

Project coverage is 87.3%. Comparing base (0bac319) to head (97d7cfb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dsh_sdk/src/schema_store/client.rs 5.0% 113 Missing ⚠️
dsh_sdk/src/certificates/bootstrap.rs 77.2% 62 Missing ⚠️
dsh_sdk/src/certificates/mod.rs 70.5% 53 Missing ⚠️
dsh_sdk/src/management_api/token_fetcher.rs 85.5% 52 Missing ⚠️
dsh_sdk/src/utils/dlq/dlq.rs 53.6% 51 Missing ⚠️
...otocol_adapters/token/data_access_token/request.rs 64.2% 40 Missing ⚠️
dsh_sdk/src/datastream/mod.rs 93.3% 34 Missing ⚠️
dsh_sdk/src/metrics.rs 0.0% 32 Missing ⚠️
...dk/src/protocol_adapters/kafka_protocol/rdkafka.rs 59.4% 30 Missing ⚠️
dsh_sdk/src/utils/platform.rs 85.4% 25 Missing ⚠️
... and 22 more
Additional details and impacted files
Files with missing lines Coverage Δ
dsh_sdk/src/dlq.rs 78.4% <ø> (ø)
dsh_sdk/src/dsh_old/bootstrap.rs 78.7% <100.0%> (ø)
dsh_sdk/src/dsh_old/certificates.rs 91.7% <ø> (ø)
dsh_sdk/src/dsh_old/config.rs 100.0% <ø> (ø)
dsh_sdk/src/dsh_old/datastream.rs 93.5% <ø> (ø)
dsh_sdk/src/dsh_old/pki_config_dir.rs 83.3% <100.0%> (ø)
dsh_sdk/src/dsh_old/properties.rs 85.6% <ø> (ø)
dsh_sdk/src/error.rs 100.0% <100.0%> (+100.0%) ⬆️
dsh_sdk/src/graceful_shutdown.rs 81.9% <ø> (ø)
...c/protocol_adapters/token/data_access_token/mod.rs 100.0% <100.0%> (ø)
... and 36 more

toelo3 and others added 17 commits January 8, 2025 16:39
* untangle errors

* update documentation

* update readme
* remove re-exports of prometheus  and lazy_static

* remove duplicated tests

* fix
* improving README.md

* Update dsh_sdk/README.md

---------

Co-authored-by: Frank Hol <frank.hol@hotmail.com>
Co-authored-by: Frank Hol <96832951+toelo3@users.noreply.github.com>
* improving documententation and comments

* improving documententation and comments

* improving documententation and commentas for dsh module

* improving documententation and commentas for certificates module

* improving documententation and commentas for datastream module

* [FIX] closure problem

* improving documententation and commentas. also added test to the errors

* remove tests from error

* improving documententation and comments for management api

* [FIX] test error problem

* [FIX] typo

* remove error example in documentation

* remove error example in documentation

* Update dsh_sdk/src/datastream/mod.rs

* Apply suggestions from code review

---------

Co-authored-by: Frank Hol <96832951+toelo3@users.noreply.github.com>
* improving documententation and comments for token fetcher

* improving documententation and comments for kafka protocol

* improving documententation and comments for schema store client

* improving documententation and comments for utils graceful shutdown

* improving documententation and comments for metric

* improving documententation and comments for platform utils

* improving documententation and comments for dead letter queue utils

* rename schema() to content()

* [fix] doc examples failures on test (incorrect imports)

* fmt

* Review token_fetcher and minor improvements

* Review and fix minor stuff in documentation

* Refactor DLQ documentation

* Review graceful_shutdown and minor improvements

* Review metrics and minor improvements

* Review platform and mino improvements

* fmt

* Fix doc warnings

* Fix doc test (missing env variable)

---------

Co-authored-by: Frank Hol <frank.hol@hotmail.com>
* rename platform methods to meaningful names
* Fix Platforms enum

* add mqtt support plus examples

* update README and examples

* update changelog and fmt
* update README and examples

* add note upgrade to v0.6

* Add AccessToken to public API

* Into instead of AsRef

* improve some minor stuff

* add fav-icon and kpn logo to docs

* cargo fmt
@toelo3 toelo3 marked this pull request as ready for review January 22, 2025 13:22
@toelo3 toelo3 merged commit 62ade9d into main Jan 22, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants