[WIP] kpt fn command to embed fn-config in a function image #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
requested review from
droot,
justinsb,
mengqiy,
martinmaly,
natasha41575 and
yuwenma
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for a
kpt fncommand that allows users to creates a new docker image that embeds the function config within the image. This allows for creating specific images from our more generic images available in the function catalog and avoid having to distribute the function config separately. It does this simply by adding a new layer to the function image that includes the function config in a well-known location (currently/localconfig/fn-config.yaml).A function can then chose to use the local config if a different one is not provided in the input (or we could say that the local always win regardless). An example of this in here.